[pat] Harden Personal Access Token name validation #14903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: SID
team: IDE
team: webapp
4 tasks
andrew-farries
approved these changes
Nov 24, 2022
| @@ -71,6 +72,21 @@ func TestTokensService_CreatePersonalAccessTokenWithoutFeatureFlag(t *testing.T) | |||
| require.Equal(t, connect.CodeInvalidArgument, connect.CodeOf(err)) | |||
| }) | |||
|
|
|||
| t.Run("invalid argument when name does not match required regex", func(t *testing.T) { | |||
| _, _, client := setupTokensService(t, withTokenFeatureDisabled) | |||
There was a problem hiding this comment.
Why is the token service configured with the token feature disabled? Not only this test but some others here too.
There was a problem hiding this comment.
Probably copy paste. It happens to work because the validation happens irrespective of whether the feature is enabled (we only check the feature enabled after we validate we got sensible arguments). I'll follow-up on this (in another PR) to reduce the confusion
easyCZ
force-pushed
the
mp/pat-validate-token-name
branch
from
c477a65 to
29bb0c8
Compare
easyCZ
force-pushed
the
mp/pat-validate-token-name
branch
from
29bb0c8 to
9e81f96
Compare
|
/unhold |
roboquat
added
deployed: webapp
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hardens Personal Access Token name validation. See regex for allowed format.
Related Issue(s)
Fixes #
How to test
Unit tests
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh